deps: update V8 to 11.1 by targos · Pull Request #46445 · nodejs/node

targos · 2023-01-31T15:41:15Z

Possibly easier to land than #46125

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 11.1. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot · 2023-01-31T15:41:21Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

nodejs-github-bot · 2023-01-31T15:53:28Z

CI: https://un5nebugbq7m6fnmhkae4.julianrbryant.com/job/node-test-pull-request/49283/

nodejs-github-bot · 2023-01-31T15:57:05Z

V8 CI: https://un5nebugbq7m6fnmhkae4.julianrbryant.com/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5151/

nodejs-github-bot · 2023-01-31T15:58:14Z

V8 CI: https://un5nebugbq7m6fnmhkae4.julianrbryant.com/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5151/

targos · 2023-02-01T08:02:33Z

V8 test failure on ppc64le and s390x:

/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:8: RangeError: Array buffer allocation failed
  const xs = new Uint16Array(3775336418);
             ^
RangeError: Array buffer allocation failed
    at new ArrayBuffer (<anonymous>)
    at new Uint16Array (<anonymous>)
    at foo (/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:8:14)
    at /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:12:1
Command: out.gn/ppc64.release/d8 --test test/mjsunit/mjsunit.js test/mjsunit/regress/regress-1320641.js --random-seed=-1674014384 --nohard-abort --testing-d8-test-runner --allow-natives-syntax

@nodejs/platform-ppc @nodejs/platform-s390

targos · 2023-02-01T08:03:49Z

Windows 32-bit build failure:

17:03:48   setup-isolate-full.cc
17:03:51 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(345,35): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
17:03:51 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(346,28): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
17:03:51 C:\workspace\node-compile-windows\node\deps\v8\src\heap\large-spaces.h(60,33): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]

@nodejs/platform-windows

targos · 2023-02-01T08:05:23Z

There seems to be an issue with WASM on ARM:

https://un5nebugbq7m6fnmhkae4.julianrbryant.com/job/node-test-binary-armv7l/4285/RUN_SUBSET=js,label=ubuntu2004-armv7l/testReport/junit/(root)/test/wpt_test_wasm_webapi/
https://un5nebugbq7m6fnmhkae4.julianrbryant.com/job/node-test-commit-arm-debug/6049/nodes=ubuntu2004_debug-arm64/testReport/junit/(root)/test/parallel_test_wasm_web_api/

@nodejs/platform-arm

gengjiawen · 2023-02-01T08:28:25Z

Windows 32-bit build failure:

17:03:48   setup-isolate-full.cc
17:03:51 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(345,35): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
17:03:51 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(346,28): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
17:03:51 C:\workspace\node-compile-windows\node\deps\v8\src\heap\large-spaces.h(60,33): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]

@nodejs/platform-windows

Similar to #45230 (comment)

cc @StefanStojanovic

targos · 2023-02-01T09:53:28Z

Oh right, I forgot that we already had this error in the past. Don't know how it came back, but based on a bisect with canary, it seems to come from https://un5x4n0kwa1t164zhzvdp2b4bu49r4r40ry9xdr.julianrbryant.com/c/v8/v8/+/4138254

targos · 2023-02-01T13:14:09Z

There's also an issue with the coverage build:

[ RUN      ] InspectorSocketTest.HostIPv6NonRoutable
../test/cctest/test_inspector_socket.cc:323: Failure
Value of: (!expectation.read_expected)
  Actual: true
Expected: false
[  FAILED  ] InspectorSocketTest.HostIPv6NonRoutable (5000 ms)

Edit: looks like it was a flake

gengjiawen · 2023-02-02T03:42:24Z

Oh right, I forgot that we already had this error in the past. Don't know how it came back, but based on a bisect with canary, it seems to come from chromium-review.googlesource.com/c/v8/v8/+/4138254

Is it possible v8 add a win32 CI ? or should we drop win 32bit too.

nodejs-github-bot · 2023-02-02T14:37:48Z

V8 CI: https://un5nebugbq7m6fnmhkae4.julianrbryant.com/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5151/

targos · 2023-02-15T07:45:02Z

Is it possible v8 add a win32 CI ? or should we drop win 32bit too.

I don't believe it, they just did (opt-in)!

https://un5h2085w35j89wkxbcf89h0br.julianrbryant.com/p/v8/issues/detail?id=8811

targos · 2023-02-24T09:45:58Z

I'll open a new PR with 11.2 later today.

targos added 7 commits January 31, 2023 16:18

deps: update V8 to 11.1.277.3

ba4a780

build: reset embedder string to "-node.0"

d46459a

src: update NODE_MODULE_VERSION to 115

6c5f87f

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 11.1. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

deps: always define V8_EXPORT_PRIVATE as no-op

9cdd2c5

dllexport introduces issues when compiling with MSVC.

deps: silence irrelevant V8 warning

4848585

PR-URL: nodejs#45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

tools: update V8 gypfiles for 11.0

38f3283

tools: update V8 gypfiles for 11.1

1e078bc

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 31, 2023

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jan 31, 2023

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2023

gengjiawen mentioned this pull request Feb 2, 2023

Should we drop support for 32 bit Windows? #42543

Closed

aduh95 mentioned this pull request Feb 18, 2023

lib: update punycode to 2.3.0 #46719

Closed

targos closed this Feb 24, 2023

targos deleted the v8-111 branch April 5, 2024 09:54

Uh oh!

Conversation

targos commented Jan 31, 2023

Uh oh!

nodejs-github-bot commented Jan 31, 2023

Uh oh!

nodejs-github-bot commented Jan 31, 2023

Uh oh!

nodejs-github-bot commented Jan 31, 2023

Uh oh!

nodejs-github-bot commented Jan 31, 2023

Uh oh!

targos commented Feb 1, 2023

Uh oh!

targos commented Feb 1, 2023

Uh oh!

targos commented Feb 1, 2023

Uh oh!

gengjiawen commented Feb 1, 2023

Uh oh!

targos commented Feb 1, 2023

Uh oh!

targos commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gengjiawen commented Feb 2, 2023

Uh oh!

nodejs-github-bot commented Feb 2, 2023

Uh oh!

targos commented Feb 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Feb 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

targos commented Feb 1, 2023 •

edited

Loading

targos commented Feb 15, 2023 •

edited

Loading