Skip to content

gh-148157: Check for _PyPegen_add_type_comment_to_arg fail in _PyPegen_name_default_pair#148158

Merged
StanFromIreland merged 2 commits intopython:mainfrom
StanFromIreland:type-cmnts
Apr 6, 2026
Merged

gh-148157: Check for _PyPegen_add_type_comment_to_arg fail in _PyPegen_name_default_pair#148158
StanFromIreland merged 2 commits intopython:mainfrom
StanFromIreland:type-cmnts

Conversation

@StanFromIreland
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland commented Apr 6, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 6, 2026
Closed
@pablogsal pablogsal added awaiting core review needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed awaiting merge labels Apr 6, 2026
@StanFromIreland StanFromIreland merged commit 1795fcc into python:main Apr 6, 2026
68 checks passed
@StanFromIreland StanFromIreland deleted the type-cmnts branch April 6, 2026 11:56
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Apr 6, 2026

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 6, 2026
@StanFromIreland @miss-islington
pythongh-148157: Check for _PyPegen_add_type_comment_to_arg fail in…
81fe44b 
… `_PyPegen_name_default_pair` (pythonGH-148158)

(cherry picked from commit 1795fccfbc7ccb89ead5c529b2f55f54622d1314)

Co-authored-by: Stan Ulbrych <stan@python.org>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 6, 2026

GH-148162 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Apr 6, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 6, 2026
@StanFromIreland @miss-islington
pythongh-148157: Check for _PyPegen_add_type_comment_to_arg fail in…
59c99be 
… `_PyPegen_name_default_pair` (pythonGH-148158)

(cherry picked from commit 1795fccfbc7ccb89ead5c529b2f55f54622d1314)

Co-authored-by: Stan Ulbrych <stan@python.org>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 6, 2026

GH-148163 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 6, 2026
@StanFromIreland
Copy link
Copy Markdown
Member Author

StanFromIreland commented Apr 6, 2026

Thanks for the review!

StanFromIreland added a commit that referenced this pull request Apr 6, 2026
@miss-islington @StanFromIreland
[3.13] gh-148157: Check for _PyPegen_add_type_comment_to_arg fail i…
4dfcdbe 
…n `_PyPegen_name_default_pair` (GH-148158) (#148163)

(cherry picked from commit 1795fcc)

Co-authored-by: Stan Ulbrych <stan@python.org>
StanFromIreland added a commit that referenced this pull request Apr 6, 2026
@miss-islington @StanFromIreland
[3.14] gh-148157: Check for _PyPegen_add_type_comment_to_arg fail i…
40a0a94 
…n `_PyPegen_name_default_pair` (GH-148158) (#148162)

(cherry picked from commit 1795fcc)

Co-authored-by: Stan Ulbrych <stan@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @pablogsal