fix(loading): remove jarring workflow loading spinners#3928
fix(loading): remove jarring workflow loading spinners#3928waleedlatif1 merged 3 commits intostagingfrom
Conversation
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit cbb844c. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR removes two
Confidence Score: 5/5Safe to merge — deletes two loading boundary files that caused visual regressions with no functional side-effects. Both deletions are correct: the [workflowId] loading.tsx was orphaned (no sibling page.tsx) and the w/ loading.tsx duplicated a spinner already rendered by w/page.tsx. No logic was changed, only UI loading states removed. No P0 or P1 issues found. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["Navigate to /workspace/:id/w/:workflowId"] --> B["Next.js App Router"]
subgraph Before["Before (with loading.tsx)"]
B1["loading.tsx fires\n(Loader2 spinner flash)"] --> B2["page.tsx renders\n(or w/page.tsx redirects\nwith its own spinner)"]
end
subgraph After["After (loading.tsx removed)"]
C1["page.tsx / w/page.tsx\nrenders directly"] --> C2["Inline spinner shown\nwhile data loads\nthen redirects"]
end
B --> Before
B --> After
style Before fill:#fee2e2,stroke:#ef4444
style After fill:#dcfce7,stroke:#22c55e
Reviews (1): Last reviewed commit: "fix(loading): remove home page skeleton ..." | Re-trigger Greptile |
* fix(loading): remove jarring workflow loading spinners * fix(loading): remove home page skeleton loading state * fix(loading): remove plain spinner loading states from task and file view
Summary
loading.tsxfrom workflow route (w/[workflowId]/) — was causing a flash of a spinner before the actual workflow page renderedloading.tsxfromw/route which has nopage.tsxand shouldn't have had a loading stateType of Change
Testing
Tested manually
Checklist