Skip to content

fix(loading): remove jarring workflow loading spinners#3928

Merged
waleedlatif1 merged 3 commits intostagingfrom
waleedlatif1/fix-workflow-loading
Apr 4, 2026
Merged

fix(loading): remove jarring workflow loading spinners#3928
waleedlatif1 merged 3 commits intostagingfrom
waleedlatif1/fix-workflow-loading

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • Removed loading.tsx from workflow route (w/[workflowId]/) — was causing a flash of a spinner before the actual workflow page rendered
  • Removed orphaned loading.tsx from w/ route which has no page.tsx and shouldn't have had a loading state

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 4, 2026

PR Summary

Low Risk
Low risk UI-only change that removes route-level loading.tsx fallbacks; main risk is a brief blank state during slow navigations if no other skeleton/loading UI exists.

Overview
Removes the loading.tsx spinner fallbacks for the workflow routes (w/[workflowId] and the orphaned w/ segment), preventing the transient spinner flash before the workflow UI renders.

Reviewed by Cursor Bugbot for commit cbb844c. Configure here.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Apr 4, 2026 0:42am

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 4, 2026

Greptile Summary

This PR removes two loading.tsx files from the Next.js App Router workflow routes to eliminate a jarring spinner flash on navigation.

  • Deletes w/[workflowId]/loading.tsx: a route-level loading boundary that caused a Loader2 spinner to flash before the workflow canvas rendered. The [workflowId] route segment has no corresponding page.tsx directly, so this loading boundary was also effectively orphaned.
  • Deletes w/loading.tsx: the PR description says this route has no page.tsx, but apps/sim/app/workspace/[workspaceId]/w/page.tsx does exist. However, that page already renders its own inline spinner while it waits for workflow data and then redirects — so the loading.tsx was causing a double-spinner effect and is correctly removed.

Confidence Score: 5/5

Safe to merge — deletes two loading boundary files that caused visual regressions with no functional side-effects.

Both deletions are correct: the [workflowId] loading.tsx was orphaned (no sibling page.tsx) and the w/ loading.tsx duplicated a spinner already rendered by w/page.tsx. No logic was changed, only UI loading states removed. No P0 or P1 issues found.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/loading.tsx Deleted — route-level Suspense boundary that caused a jarring Loader2 spinner flash before the workflow canvas appeared; correctly removed.
apps/sim/app/workspace/[workspaceId]/w/loading.tsx Deleted — duplicate loading UI that conflicted with the inline spinner already rendered by w/page.tsx during its redirect flow.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Navigate to /workspace/:id/w/:workflowId"] --> B["Next.js App Router"]

    subgraph Before["Before (with loading.tsx)"]
        B1["loading.tsx fires\n(Loader2 spinner flash)"] --> B2["page.tsx renders\n(or w/page.tsx redirects\nwith its own spinner)"]
    end

    subgraph After["After (loading.tsx removed)"]
        C1["page.tsx / w/page.tsx\nrenders directly"] --> C2["Inline spinner shown\nwhile data loads\nthen redirects"]
    end

    B --> Before
    B --> After

    style Before fill:#fee2e2,stroke:#ef4444
    style After fill:#dcfce7,stroke:#22c55e
Loading

Reviews (1): Last reviewed commit: "fix(loading): remove home page skeleton ..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit 2334f2d into staging Apr 4, 2026
6 checks passed
@waleedlatif1 waleedlatif1 deleted the waleedlatif1/fix-workflow-loading branch April 4, 2026 00:45
waleedlatif1 added a commit that referenced this pull request Apr 4, 2026
* fix(loading): remove jarring workflow loading spinners

* fix(loading): remove home page skeleton loading state

* fix(loading): remove plain spinner loading states from task and file view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant