improvement(models): tighten model metadata and crawl discovery#3942
improvement(models): tighten model metadata and crawl discovery#3942waleedlatif1 merged 7 commits intostagingfrom
Conversation
Made-with: Cursor
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 29606901 | Triggered | Generic High Entropy Secret | 35c939e | apps/sim/providers/utils.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
PR SummaryMedium Risk Overview Expands provider model definitions with many explicit Enhances crawl discovery by updating Reviewed by Cursor Bugbot for commit 569031c. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR tightens model metadata across the catalog (publishing explicit Key changes:
Confidence Score: 5/5Safe to merge — all changes are additive metadata improvements with no runtime risk. The only finding is a P2 style issue (relative import in a new test file). All substantive logic changes are well-tested, and the prior P1 concern about overbroad structured-output copy has been fully addressed. No data loss, security, or correctness risk present. apps/sim/app/(landing)/models/utils.test.ts — single relative import to fix Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Model capabilities] --> B{deepResearch?}
B -- yes --> C[bestFor: null\nstructuredOutputs: Not supported]
B -- no --> D{reasoningEffort\nor thinking?}
D -- yes --> E[bestFor: reasoning-heavy tasks]
D -- no --> F{contextWindow\n≥ 1M tokens?}
F -- yes --> G[bestFor: long-context workflows]
F -- no --> H{nativeStructuredOutputs?}
H -- yes --> I[bestFor: typed outputs\n+4 relevance score]
H -- no --> J{cheap pricing?}
J -- yes --> K[bestFor: cost-sensitive workloads]
J -- no --> L[bestFor: null]
A --> M{maxOutputTokens set?}
M -- yes --> N[Display published limit\ngetEffectiveMaxOutputTokens]
M -- no --> O[Display: Not published]
Reviews (3): Last reviewed commit: "models" | Re-trigger Greptile |
Made-with: Cursor
Made-with: Cursor
|
@greptile |
|
@cursor review |
Made-with: Cursor
|
Restored the section, but only as an optional high-signal field. It now shows up for clearly differentiated models (for example deep research, reasoning-heavy, long-context, native structured outputs, or unusually cheap models) and stays hidden for generic models instead of falling back to repetitive copy. |
|
@cursor review |
|
@greptile |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 569031c. Configure here.
* improvement(models): tighten model metadata and crawl discovery Made-with: Cursor * revert hardcoded FF * fix(models): narrow structured output ranking signal Made-with: Cursor * fix(models): remove generic best-for copy Made-with: Cursor * fix(models): restore best-for with stricter criteria Made-with: Cursor * fix * models
Summary
llms.txtrouteType of Change
Testing
Tested manually
bun run lintbun run testbun run type-checkcurrently fails in existing auth/better-auth code unrelated to this branchChecklist
Made with Cursor