feat(triggers): add HubSpot merge, restore, and generic webhook triggers#3983
feat(triggers): add HubSpot merge, restore, and generic webhook triggers#3983waleedlatif1 merged 4 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Updates HubSpot trigger discovery/UI wiring ( Reviewed by Cursor Bugbot for commit c9487c2. Configure here. |
Greptile SummaryThis PR expands the HubSpot integration by adding 10 new trigger configurations: merge and restore events for contacts, companies, deals, and tickets, plus a generic webhook trigger that captures all HubSpot events. The implementation follows existing HubSpot trigger patterns faithfully — each trigger has the correct credential sub-blocks, curl command setup instructions, sample payloads, and merge-specific outputs (with
Confidence Score: 5/5This PR is safe to merge — all findings are P2 style suggestions with no runtime impact All three flagged issues are TypeScript style violations (as any, Record<string, any>, misleading function name) that do not affect runtime behavior. The new triggers correctly implement the confirmed-valid HubSpot API v3 event types and follow established project patterns faithfully. apps/sim/triggers/hubspot/utils.ts has two minor TypeScript hygiene issues (as any cast and misleading function name) worth cleaning up Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[HubSpot sends POST webhook] --> B[Sim webhook endpoint]
B --> C{isHubSpotEventMatch check}
C -->|contact.merge| D[hubspot_contact_merged]
C -->|contact.restore| E[hubspot_contact_restored]
C -->|company.merge| F[hubspot_company_merged]
C -->|company.restore| G[hubspot_company_restored]
C -->|deal.merge| H[hubspot_deal_merged]
C -->|deal.restore| I[hubspot_deal_restored]
C -->|ticket.merge| J[hubspot_ticket_merged]
C -->|ticket.restore| K[hubspot_ticket_restored]
C -->|unknown triggerId returns true| L[hubspot_webhook\nAll Events passthrough]
D & E & F & G & H & I & J & K --> M[Workflow execution\ntyped outputs incl. mergedObjectIds]
L --> N[Workflow execution\ngeneric event payload]
Reviews (2): Last reviewed commit: "lint" | Re-trigger Greptile |
…setup instructions
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c9487c2. Configure here.
…ers (#3983) * feat(triggers): add HubSpot merge, restore, and generic webhook triggers * fix(triggers): add mergedObjectIds to merge trigger output schemas * fix(triggers): derive correct OAuth scope per HubSpot object type in setup instructions * lint
Summary
Type of Change
Testing
Tested manually
Checklist