ICU-23337 Fix undefined behavior in list_format_fuzzer: validate enum values#3890
Open
OwenSanzas wants to merge 1 commit intounicode-org:mainfrom
Open
ICU-23337 Fix undefined behavior in list_format_fuzzer: validate enum values#3890OwenSanzas wants to merge 1 commit intounicode-org:mainfrom
OwenSanzas wants to merge 1 commit intounicode-org:mainfrom
Conversation
…om fuzz data The harness reads UListFormatterType and UListFormatterWidth directly from fuzz data via memcpy into enum variables without validation. Loading arbitrary bit patterns into C++ enum types is undefined behavior, confirmed by UndefinedBehaviorSanitizer: runtime error: load of value 2125315823, which is not a valid value for type 'UListFormatterType' The fix reads into int32_t first, then clamps to valid enum ranges before casting. The redundant third createInstance call (which was the only one using validated values) is removed since the second call now uses validated values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
list_format_fuzzerharness readsUListFormatterTypeandUListFormatterWidthdirectly from fuzz data viamemcpyinto enum variables without validation. Loading arbitrary bit patterns into C++ enum types is undefined behavior.Confirmed with UndefinedBehaviorSanitizer:
The harness already validates these values for a third
createInstancecall (lines 58-61), but passes the raw unvalidated values in the second call (line 52).Changes
int32_tinstead of directly into enum types (eliminates UB at thememcpypoint)createInstancecall — it was only needed because the second call used unvalidated values; now the second call uses validated values directlyExperimental Verification (60-second fuzzing, AddressSanitizer)
Coverage is equivalent — the fix eliminates the UB without affecting fuzzing effectiveness.
UBSan Evidence
type=0x7EADBEEF, width=0x7EADBEEF