[css2] Fix wording for magins collapsing#13699
Open
Conversation
This matches the notes below and also matches implementations.
Contributor
Author
|
I'm also wondering whether or not the spec should really say "zero computed min-height" and "zero or auto computed height". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the notes below that section and also matches implementations.
Consider:
The current spec suggests that, since this paragraph has an in-flow child, its margins should not collapse, when in reality, all the margins here collapse into a single
1emgap, because there's nothing in-between.