Skip to content

[cssom-view] Remove "familiar with" check for move/resize methods#6300

Merged
emilio merged 1 commit intow3c:mainfrom
domenic:no-incumbent
Jul 29, 2021
Merged

[cssom-view] Remove "familiar with" check for move/resize methods#6300
emilio merged 1 commit intow3c:mainfrom
domenic:no-incumbent

Conversation

@domenic
Copy link
Copy Markdown
Collaborator

@domenic domenic commented May 20, 2021

Closes #1725 by removing the usage of incumbent settings object. I could find no evidence of such a check in the Blink, Gecko, or WebKit codebases. Indeed, such a check should not generally be necessary, as (unlike, e.g., window.close()) these methods are not accessible cross-origin.

Also includes various changes for things that have updated in other specs:

  • Use "this" instead of "context object"
  • Use "string is" instead of "case-sensitive"
  • Use "start node" and "start offset" instead of referring to properties of Range (or now, AbstractRange)
  • Link to the correct "event loop" definition
  • Remove redundant anchor blocks, as these days most definitions are properly exported

Closes #1725 by removing the usage of incumbent settings object. I could find no evidence of such a check in the Blink, Gecko, or WebKit codebases. Indeed, such a check should not generally be necessary, as (unlike, e.g., window.close()) these methods are not accessible cross-origin.

Also includes various changes for things that have updated in other specs:

* Use "this" instead of "context object"
* Use "string is" instead of "case-sensitive"
* Use "start node" and "start offset" instead of referring to properties of Range (or now, AbstractRange)
* Link to the correct "event loop" definition
* Remove redundant anchor blocks, as these days most definitions are properly exported
@tabatkins
Copy link
Copy Markdown
Member

ping @emilio

@emilio emilio merged commit ec8ace9 into w3c:main Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cssom-view] Stop using "incumbent settings object"?

3 participants