Merged
Conversation
wpt-pr-bot
approved these changes
May 3, 2018
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
Already reviewed downstream.
0d42c08 to
3abcf4e
Compare
3abcf4e to
c53343c
Compare
Removes document.createTouch and related tests createTouchList has relatively high UseCount(around 0.015%), see https://un5gmtkzggycwe7krnd28.julianrbryant.com/metrics/feature/timeline/popularity/2368 We need to address these use cases before remove it. Postpone createTouchList removal to M69 intent to deprecate and Remove: https://un5q0n0ruuqx6vxrwk2rxd8.julianrbryant.com/a/chromium.org/forum/#!topic/blink-dev/GLbUpUUnQzc PR to touch-events spec: w3c/touch-events#96 Bug: 518868 Change-Id: If086b51b775e4be59320c4a1329988787ff6f870 Reviewed-on: https://un5x4n0kwa1t164zhzvdp2b4bu49r4r40ry9xdr.julianrbryant.com/1041128 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#557907}
c53343c to
9e43169
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes document.createTouch and related tests
createTouchList has relatively high UseCount(around 0.015%), see
https://un5gmtkzggycwe7krnd28.julianrbryant.com/metrics/feature/timeline/popularity/2368
We need to address these use cases before remove it.
Postpone createTouchList removal to M69
intent to deprecate and Remove:
https://un5q0n0ruuqx6vxrwk2rxd8.julianrbryant.com/a/chromium.org/forum/#!topic/blink-dev/GLbUpUUnQzc
PR to touch-events spec:
w3c/touch-events#96
Bug: 518868
Change-Id: If086b51b775e4be59320c4a1329988787ff6f870
Reviewed-on: https://un5x4n0kwa1t164zhzvdp2b4bu49r4r40ry9xdr.julianrbryant.com/1041128
Commit-Queue: Ella Ge eirage@chromium.org
Reviewed-by: Navid Zolghadr nzolghadr@chromium.org
Reviewed-by: David Bokan bokan@chromium.org
Reviewed-by: Bo boliu@chromium.org
Reviewed-by: Rick Byers rbyers@chromium.org
Cr-Commit-Position: refs/heads/master@{#557907}