[Gecko Bug 2024601] patch 2 - Add evaluation tests involving substitution functions.#58953
Open
moz-wptsync-bot wants to merge 2 commits intomasterfrom
Open
[Gecko Bug 2024601] patch 2 - Add evaluation tests involving substitution functions.#58953moz-wptsync-bot wants to merge 2 commits intomasterfrom
moz-wptsync-bot wants to merge 2 commits intomasterfrom
Conversation
The existing WPTs check that these forms can be parsed, but not that they actually work at matching time. So this adds a few examples to the query-evaluation test. They won't pass in Firefox until support for these functions is hooked up. (Confirmed that these work as expected in Chrome.) Differential Revision: https://un5qehb4k2wtmzpgqqtb9jtw1ehttwx37hbg.julianrbryant.com/D290903 bugzilla-url: https://un5h208565ak8emkwgjjkgb49yug.julianrbryant.com/show_bug.cgi?id=2024601 gecko-commit: eeee1edec2ba8c799e6dbb761a8aabcf2c499e0f gecko-commit-git: edca4e6c52ff14c3be464febd1340ba76a30a7ca gecko-reviewers: firefox-style-system-reviewers, emilio
Differential Revision: https://un5qehb4k2wtmzpgqqtb9jtw1ehttwx37hbg.julianrbryant.com/D290988 bugzilla-url: https://un5h208565ak8emkwgjjkgb49yug.julianrbryant.com/show_bug.cgi?id=2024601 gecko-commit: 26595abfd68c8dec5e2e7075be041bbe4a3c5c87 gecko-commit-git: 82b73cac260b1ee65cc1b35e4c004538ca9f2d5b gecko-reviewers: firefox-style-system-reviewers, dshin
wpt-pr-bot
approved these changes
Apr 2, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing WPTs check that these forms can be parsed, but not that they actually work
at matching time. So this adds a few examples to the query-evaluation test. They won't
pass in Firefox until support for these functions is hooked up.
(Confirmed that these work as expected in Chrome.)
Differential Revision: https://un5qehb4k2wtmzpgqqtb9jtw1ehttwx37hbg.julianrbryant.com/D290903
bugzilla-url: https://un5h208565ak8emkwgjjkgb49yug.julianrbryant.com/show_bug.cgi?id=2024601
gecko-commit: eeee1edec2ba8c799e6dbb761a8aabcf2c499e0f
gecko-commit-git: edca4e6c52ff14c3be464febd1340ba76a30a7ca
gecko-reviewers: firefox-style-system-reviewers, emilio